Skip to content

308 remove name - #313

Open
rozyczko wants to merge 5 commits into
release-3.0from
308-remove-name
Open

308 remove name#313
rozyczko wants to merge 5 commits into
release-3.0from
308-remove-name

Conversation

@rozyczko

@rozyczko rozyczko commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Refactoring of Descriptor and Parameter Naming

  • Refactored all usages of name to use display_name for Parameter instantiation

  • Updated code that accesses parameter/descriptor names to use display_name instead of name

Modernization of Descriptor Class Constructors

  • Changed constructors of DescriptorAnyType and DescriptorArray to remove the name positional argument, making all arguments after value keyword-only.

@rozyczko rozyczko added [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] highest Urgent. Needs attention ASAP [area] parameters and descriptors Anything related to Parameters or Descriptors [area] base classes Changes to or creation of new base classes labels Sep 25, 2026
@codecov

codecov Bot commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.48%. Comparing base (22513ad) to head (38a8131).
⚠️ Report is 1 commits behind head on release-3.0.

Files with missing lines Patch % Lines
src/easyscience/variable/descriptor_number.py 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0     #313      +/-   ##
===============================================
- Coverage        83.82%   83.48%   -0.34%     
===============================================
  Files               69       69              
  Lines             5272     5188      -84     
===============================================
- Hits              4419     4331      -88     
- Misses             853      857       +4
Flag Coverage Δ
unittests 83.48% <98.11%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...syscience/fitting/calculators/interface_factory.py 97.27% <100.00%> (ø)
src/easyscience/models/polynomial.py 100.00% <100.00%> (ø)
src/easyscience/variable/descriptor_any_type.py 96.87% <100.00%> (ø)
src/easyscience/variable/descriptor_array.py 89.12% <100.00%> (-0.45%) ⬇️
src/easyscience/variable/descriptor_base.py 96.29% <100.00%> (+0.46%) ⬆️
src/easyscience/variable/descriptor_bool.py 100.00% <100.00%> (+3.57%) ⬆️
src/easyscience/variable/descriptor_str.py 100.00% <100.00%> (ø)
src/easyscience/variable/parameter.py 95.06% <100.00%> (-0.25%) ⬇️
...yscience/variable/parameter_dependency_resolver.py 69.87% <ø> (ø)
src/easyscience/variable/descriptor_number.py 94.77% <93.33%> (-0.64%) ⬇️

... and 1 file with indirect coverage changes

@rozyczko rozyczko mentioned this pull request Sep 25, 2026
Open
@rozyczko
rozyczko marked this pull request as ready for review September 25, 2026 13:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damskii9992 damskii9992 Awaiting requested review from damskii9992

Assignees

No one assigned

Labels

[area] base classes Changes to or creation of new base classes [area] parameters and descriptors Anything related to Parameters or Descriptors [priority] highest Urgent. Needs attention ASAP [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rozyczko